Abstract away the TestServer dependency from WebApplicationBuilder #60247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-networking
mkArtakMSFT
force-pushed
the
mkArtakMSFT/issue_4892
branch
2 times, most recently
from
8cf15f6 to
9c0fb14
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 12 changed files in this pull request and generated no comments.
Files not reviewed (7)
- src/Hosting/TestHost/src/PublicAPI.Unshipped.txt: Language not supported
- src/Mvc/Mvc.Testing/src/PublicAPI.Unshipped.txt: Language not supported
- src/Mvc/Mvc.Testing/src/Resources.resx: Language not supported
- src/Mvc/test/Mvc.FunctionalTests/ApiExplorerTest.cs: Evaluated as low risk
- src/Mvc/test/Mvc.FunctionalTests/Infrastructure/MvcTestFixture.cs: Evaluated as low risk
- src/Identity/test/Identity.FunctionalTests/Infrastructure/ServerFactory.cs: Evaluated as low risk
- src/Mvc/test/Mvc.FunctionalTests/ComponentRenderingFunctionalTests.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
src/Mvc/Mvc.Testing/src/WebApplicationFactory.cs:161
- [nitpick] The method name 'Initialize' might be too generic. Consider renaming it to 'InitializeServer' for better clarity.
public void Initialize()
|
Still battling the issue introduced by the relative contentRoot change. |
3 tasks
|
@mkArtakMSFT We'll need to do an API review for this since it includes a changes to the WAF interface. Have you had the chance to use these changes with a Playwright-based setup? |
mkArtakMSFT
force-pushed
the
mkArtakMSFT/issue_4892
branch
from
e5aff71 to
bfa3c20
Compare
Will do! |
…ency with from in the WebApplicationFactory. - Updated the WebApplicationFactory to depend on the ITestServer abstraction
- Fixed the public API declarations - React to changes in the WebApplicationFactory - Use solution-relative contentRoot path, when the path from metadata either is not available or doesn't exist. - If none of the paths exist, use the AppContext.BaseDirectory instead. - Fix tests with outdated expectations
mkArtakMSFT
force-pushed
the
mkArtakMSFT/issue_4892
branch
from
bfa3c20 to
1f62155
Compare
|
I have discovered an issue where the ITestServer creation happens through two different flows. I'm looking into whether this needs to be unified or not. Will update the PR once that's cleared. |
mkArtakMSFT
force-pushed
the
mkArtakMSFT/issue_4892
branch
from
c0a16cc to
1f62155
Compare
…er as obsolete and introduce a new CreateTestServer method.
3 tasks
dotnet-policy-service
bot
added
the
pending-ci-rerun
This was referenced Mar 5, 2025
|
Closing as we will be taking the alternative approach provided via #60635 |
mkArtakMSFT
added a commit
that referenced
this pull request
Mar 28, 2025
- Added `UseKestrel(...)` APIs to the WebApplicationFactory<T> type. The API configures the WAF, so that later during initialization it will use Kestrel, instead of a TestServer for WebHostBuilder-based applications. - Two different overloads (described in the API Proposal #60758) are added - Renamed the `EnsureServer()` private method to `StartServer()` and made it public, so that consumers can call it directly, without the need of creating a client, as in many situations customers didn't need a client to interact with. This is an alternative design to enabling real server usage with WebApplicationFactory, which was considered here: #60247 Fixes #4892
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Validation
How do I know if this change didn't break something? Well, at first it did and many integration tests in the repo started failing. So these, naturally become a validation ground for this change.
Fixes #4892